Discussion:
[PATCH] avr32: Fix build error caused by include file reshuffling
(too old to reply)
Guenter Roeck
2017-03-06 01:05:57 UTC
Permalink
Raw Message
Various avr32 builds fail as follows.

arch/avr32/oprofile/backtrace.c:58: error:
dereferencing pointer to incomplete type
arch/avr32/oprofile/backtrace.c:60: error:
implicit declaration of function 'user_mode'

Fixes: f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from ...")
Cc: Ingo Molnar <***@kernel.org>
Signed-off-by: Guenter Roeck <***@roeck-us.net>
---
Please feel free to ignore if av32 is going to be removed.

arch/avr32/oprofile/backtrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/avr32/oprofile/backtrace.c b/arch/avr32/oprofile/backtrace.c
index 75d9ad6f99cf..29cf2f191bfd 100644
--- a/arch/avr32/oprofile/backtrace.c
+++ b/arch/avr32/oprofile/backtrace.c
@@ -14,7 +14,7 @@
*/

#include <linux/oprofile.h>
-#include <linux/sched.h>
+#include <linux/ptrace.h>
#include <linux/uaccess.h>

/* The first two words of each frame on the stack look like this if we have
--
2.7.4
Hans-Christian Noren Egtvedt
2017-03-06 07:12:38 UTC
Permalink
Raw Message
Post by Guenter Roeck
Various avr32 builds fail as follows.
dereferencing pointer to incomplete type
implicit declaration of function 'user_mode'
Fixes: f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from ...")
---
Please feel free to ignore if av32 is going to be removed.
AVR32 is not going away for 4.11, we started the FYI and review process too
late to make the window.

I think I will push it, to make sure AVR32 leaves the kernel in as good state
as possible.
Post by Guenter Roeck
arch/avr32/oprofile/backtrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/avr32/oprofile/backtrace.c b/arch/avr32/oprofile/backtrace.c
index 75d9ad6f99cf..29cf2f191bfd 100644
--- a/arch/avr32/oprofile/backtrace.c
+++ b/arch/avr32/oprofile/backtrace.c
@@ -14,7 +14,7 @@
*/
#include <linux/oprofile.h>
-#include <linux/sched.h>
+#include <linux/ptrace.h>
#include <linux/uaccess.h>
/* The first two words of each frame on the stack look like this if we have
--
mvh
Hans-Christian Noren Egtvedt
Loading...