Discussion:
[PATCH 0813/1285] Replace numeric parameter like 0444 with macro
(too old to reply)
Baole Ni
2016-08-02 11:48:59 UTC
Permalink
Raw Message
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <***@intel.com>
Signed-off-by: Baole Ni <***@intel.com>
---
drivers/oprofile/oprof.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/oprofile/oprof.c b/drivers/oprofile/oprof.c
index ed2c3ec..622e370 100644
--- a/drivers/oprofile/oprof.c
+++ b/drivers/oprofile/oprof.c
@@ -278,7 +278,7 @@ static void __exit oprofile_exit(void)
module_init(oprofile_init);
module_exit(oprofile_exit);

-module_param_named(timer, timer, int, 0644);
+module_param_named(timer, timer, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(timer, "force use of timer interrupt");

MODULE_LICENSE("GPL");
--
2.9.2


------------------------------------------------------------------------------
Loading...